> On 8/9/23 11:25 PM, Ziyang Xuan wrote: >> When use bpf_skb_adjust_room() to encapsulate or decapsulate packet, >> and outer protocol changed, we can update h_proto of ethhdr directly. > > My mailbox somehow lost patch 1/2. > > Looks like current bpf_skb_adjust_room() only changes skb meta data and > tries not to modify the packet. Probably there is a reason for this. > I found that this could reduce updating h_proto of ethhdr by bpf_skb_store_bytes() in bpf program when I used bpf_skb_adjust_room(). I thought it should be a small optimization. So I did it. No other problems. Thank you! William Xuan >> >> $./test_tc_tunnel.sh >> ipip >> encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100 >> test basic connectivity >> 0 >> test bpf encap without decap (expect failure) >> Ncat: TIMEOUT. >> 1 >> test bpf encap with tunnel device decap >> 0 >> test bpf encap with bpf decap >> 0 >> OK >> ipip6 > [...] > > .
