On Tue, Aug 08, 2023 at 01:46:47PM -0400, Hugo Villeneuve wrote: > On Tue, 8 Aug 2023 10:21:03 -0700 > Breno Leitao <leitao@xxxxxxxxxx> wrote: > > > Hello Hugo, > > > > On Tue, Aug 08, 2023 at 12:13:23PM -0400, Hugo Villeneuve wrote: > > > On Tue, 8 Aug 2023 06:40:41 -0700 > > > Breno Leitao <leitao@xxxxxxxxxx> wrote: > > > > > > > Exposing function sock_use_custom_sol_socket(), so it could be used by > > > > io_uring subsystem. > > > > > > > > This function will be used in the function io_uring_cmd_setsockopt() in > > > > the coming patch, so, let's move it to the socket.h header file. > > > > > > Hi, > > > this description doesn't seem to match the code change below... > > > > I re-read the patch comment and it seems to match what the code does, > > so, probably this description only makes sense to me (?). > > > > That said, hat have you understood from reading the description above? > > socket.h > > Thanks for the review, > > Hi Breno, > your comments says "move it to the socket.h header file" but it seems > to be moved to the net.h header file? Gotcha. Thanks. I will update.
