Re: [PATCH bpf-next] selftests/bpf: remove duplicated functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/7/23 12:38 PM, thinker.li@xxxxxxxxx wrote:
From: Kui-Feng Lee <thinker.li@xxxxxxxxx>

The file cgroup_tcp_skb.c contains redundant implementations of the similar
functions (create_server_sock_v6() and connect_client_server_v6()) found in
network_helpers.c. Let's eliminate these duplicated functions.

How about the port function mentioned in https://lore.kernel.org/bpf/c2776380-7550-3777-24a0-1f155785696c@xxxxxxxxx/ :

>> There is get_socket_local_port() that supports both v4 and v6 in
>> network_helpers.c which is equivalent to the get_sock_port_v6() here.





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux