On 8/3/23 18:32, Yonghong Song wrote:
On 8/3/23 4:12 PM, thinker.li@xxxxxxxxx wrote:
From: Kui-Feng Lee <thinker.li@xxxxxxxxx>
Verify if the pointer obtained from bpf_xdp_pointer() is either an
error or
NULL before returning it.
The function bpf_dynptr_slice() mistakenly returned an ERR_PTR.
Instead of
solely checking for NULL, it should also verify if the pointer
returned by
bpf_xdp_pointer() is an error or NULL.
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Closes:
https://lore.kernel.org/bpf/d1360219-85c3-4a03-9449-253ea905f9d1@moroto.mountain/
Fixes: 66e3a13e7c2c ("bpf: Add bpf_dynptr_slice and
bpf_dynptr_slice_rdwr")
Suggested-by: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>
Signed-off-by: Kui-Feng Lee <thinker.li@xxxxxxxxx>
Acked-by: Yonghong Song <yonghong.song@xxxxxxxxx>
Thanks!