Re: [PATCH net-next 0/2] team: change return value of init and getter in the team_option structure to void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2023/8/4 19:44, Jiri Pirko wrote:
Fri, Aug 04, 2023 at 01:28:23PM CEST, shaozhengchao@xxxxxxxxxx wrote:
Because the init and getter function always returns 0, so change return
value of init and getter in the team_option structure to void and remove
redundant code.

Reading this 5 times, I don't understand the sentence :/

Also, why you send 2 patchsets and 2 seperate patches, all for team? Why
don't you send it as one 6-patch patchset?

Hi Jiri:
	Thank you for review. I will send a patchset.

Zhengchao Shao


Zhengchao Shao (2):
  team: change return value of init in the team_option structure to void
  team: change return value of getter in the team_option structure to
    void

drivers/net/team/team.c                   | 60 +++++++++--------------
drivers/net/team/team_mode_activebackup.c |  8 ++-
drivers/net/team/team_mode_loadbalance.c  | 39 ++++++---------
include/linux/if_team.h                   |  4 +-
4 files changed, 44 insertions(+), 67 deletions(-)

--
2.34.1






[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux