> skb_do_redirect returns various of values: error code (negative),
> 0 (success), and some positive status code, e.g. NET_XMIT_CN,
How do you think about to use a wording variant (like the following)?
skb_do_redirect() returns different value kinds so far:
Can it be nicer to use a multi-line enumeration here?
> NET_RX_DROP. Commit 3a0af8fd61f9 ("bpf: BPF for lightweight tunnel
I suggest to start this sentence on a separate line.
Can the commit specification fit into the same line then?
…
> https://gist.github.com/zhaiyan920/8fbac245b261fe316a7ef04c9b1eba48
Can it help to mention here that you would like to refer to
a complete KASAN report (which contains 89 text lines then)?
> Convert positive statuses from skb_do_redirect eliminates this issue.
Would you like to avoid another wording weakness in this sentence?
How do you think about to use the following wording variant?
Thus convert positive status values from the execution of
the function “skb_do_redirect” into special error codes.
…
> Suggested-by: Markus Elfring
…
I dare to point review concerns out for various software components.
But I did not get the impression that I suggested the patch idea.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n584
Thus I find this tag inappropriate here.
Would any information become more relevant for related version descriptions?
Regards,
Markus
