From: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> Date: Wed, 19 Jul 2023 18:42:17 +0200 > From: Yunsheng Lin <linyunsheng@xxxxxxxxxx> > Date: Wed, 19 Jul 2023 20:13:37 +0800 > >> Split types and pure function declarations from page_pool.h >> and add them in page_page_types.h, so that C sources can >> include page_pool.h and headers should generally only include >> page_pool_types.h as suggested by jakub. >> >> Signed-off-by: Yunsheng Lin <linyunsheng@xxxxxxxxxx> >> Suggested-by: Jakub Kicinski <kuba@xxxxxxxxxx> >> CC: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> > Nice! > > Let me take it into my tree, I assume it's safe to say it will be > accepted sooner than my patches :D FYI: it's already there (since yesterday), including your hybrid allocation series, so for the next revision you could take it from there to not rebase it one more time :) ...except that seems like I have to rebase it once again now that you change the patch to add new folder as Jakub asked. (it's still the same iavf-pp-frag) > > BTW, what do you think: is it better to have those two includes in the > root include/net/ folder or do something like > > include/net/page_pool/ > * types.h > * <some meaningful name>.h (let's say driver.h) > > like it's done e.g. for GPIO (see include/linux/gpio/)? > > Thanks, > Olek Thanks, Olek
