Re: [PATCH bpf-next] selftests/bpf: fix ringbuf benchmark output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 18, 2023 at 6:50 PM Andrew Werner <awerner32@xxxxxxxxx> wrote:
>
> The headers were confusing.
> ---

SOB is missing.

commit log is too terse.
Pls explain what you're fixing.

>  tools/testing/selftests/bpf/benchs/run_bench_ringbufs.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/benchs/run_bench_ringbufs.sh b/tools/testing/selftests/bpf/benchs/run_bench_ringbufs.sh
> index 91e3567962ff..8dd97f5108f0 100755
> --- a/tools/testing/selftests/bpf/benchs/run_bench_ringbufs.sh
> +++ b/tools/testing/selftests/bpf/benchs/run_bench_ringbufs.sh
> @@ -6,12 +6,12 @@ set -eufo pipefail
>
>  RUN_RB_BENCH="$RUN_BENCH -c1"
>
> -header "Single-producer, parallel producer"
> +header "Single-consumer, parallel producer"
>  for b in rb-libbpf rb-custom pb-libbpf pb-custom; do
>         summarize $b "$($RUN_RB_BENCH $b)"
>  done
>
> -header "Single-producer, parallel producer, sampled notification"
> +header "Single-consumer, parallel producer, sampled notification"

Single-producer, consumer/producer competing on the same CPU, low batch count

should also be fixed?





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux