This is a small follow up to the conversation with Hou in the following thread: https://lore.kernel.org/bpf/20230705160139.19967-1-aspsk@xxxxxxxxxxxxx/T/#u Namely, the conversation was about that comments in <linux/bpf.h> describing the return values from the batch operations are not 100% obvious. I tried to make comments more clear. While doing this I also found that this is better to patch how __htab_map_lookup_and_delete_batch sets return values: the output parameter count could be set to non-zero in case of error, which may confuse some userspace apps (as errno && non-zero counter is considered a partially successful operation for batch ops). Anton Protopopov (2): bpf: fix setting return values for htab batch ops bpf: update uapi/linux/bpf.h docs on the batch map ops include/uapi/linux/bpf.h | 22 ++++++++++++---------- kernel/bpf/hashtab.c | 14 +++++++------- 2 files changed, 19 insertions(+), 17 deletions(-) -- 2.34.1
