On Fri, Jul 14, 2023 at 4:33 PM Dave Thaler <dthaler@xxxxxxxxxxxxx> wrote: > > Yonghong Song <yhs@xxxxxx> wrote: > > Add documentation in instruction-set.rst for new instruction encoding and > > their corresponding operations. Also removed the question related to 'no > > BPF_SDIV' in bpf_design_QA.rst since we have BPF_SDIV insn now. > > Why did you choose to differentiate the instruction by offset instead of using a separate > opcode value? I don't think there's any other instructions that do so, and there's spare > opcode values as far as I can see. > > Using a separate offset works but would end up requiring another column in the IANA > registry assuming we have one. So why the extra complexity and inconsistency > introduced now? "another column in IANA" is the last thing to worry about.
