On Sun, Jul 9, 2023 at 9:05 PM Ravi Bangoria <ravi.bangoria@xxxxxxx> wrote:
>
> On 08-Jul-23 4:46 AM, Andrii Nakryiko wrote:
> > On Wed, Jul 5, 2023 at 9:39 PM Ravi Bangoria <ravi.bangoria@xxxxxxx> wrote:
> >>
> >> Hi Andrii,
> >>
> >> I'm seeing perf test failure because of commit d6e6286a12e7 ("libbpf:
> >> disassociate section handler on explicit bpf_program__set_type() call").
> >>
> >
> > Yep, this commit would reset catch-all custom handler, which perf is
> > setting. I've just sent a fix upstream ([0]). And once it lands, I'll
> > cut a v1.2.1 libbpf bugfix release with just this fix on top of v1.2.
> >
> > Can you please double-check that this patch indeed fixes the issue for
> > you? I tried to do this locally, but for me perf test 42 fails both at
> > current bpf-next, with the above commit reverted, and with my fix
> > applied on top. So I can't be 100% sure.
> >
> > Thanks!
> >
> > [0] https://patchwork.kernel.org/project/netdevbpf/patch/20230707231156.1711948-1-andrii@xxxxxxxxxx/
>
> Thanks. A quick test seems to be working fine.
Alright, thanks for confirming! I've just released v1.2.1 bug fix
release with just this fix on top of v1.2.
Thanks for reporting!
But given v1.2 was cut on May 1st, and the offending commit landed
some time late March, I wonder how did this slip through the cracks
and go unreported for so long? Is there something we can do to catch
these perf-only regressions a bit sooner?
>
> Ravi
