Re: [PATCH v2 86/92] bpf: convert to ctime accessor functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 05-07-23 15:01:51, Jeff Layton wrote:
> In later patches, we're going to change how the inode's ctime field is
> used. Switch to using accessor functions instead of raw accesses of
> inode->i_ctime.
> 
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  kernel/bpf/inode.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/bpf/inode.c b/kernel/bpf/inode.c
> index 4174f76133df..99d0625b6c82 100644
> --- a/kernel/bpf/inode.c
> +++ b/kernel/bpf/inode.c
> @@ -118,9 +118,8 @@ static struct inode *bpf_get_inode(struct super_block *sb,
>  		return ERR_PTR(-ENOSPC);
>  
>  	inode->i_ino = get_next_ino();
> -	inode->i_atime = current_time(inode);
> +	inode->i_atime = inode_set_ctime_current(inode);
>  	inode->i_mtime = inode->i_atime;
> -	inode->i_ctime = inode->i_atime;
>  
>  	inode_init_owner(&nop_mnt_idmap, inode, dir, mode);
>  
> @@ -148,8 +147,7 @@ static void bpf_dentry_finalize(struct dentry *dentry, struct inode *inode,
>  	d_instantiate(dentry, inode);
>  	dget(dentry);
>  
> -	dir->i_mtime = current_time(dir);
> -	dir->i_ctime = dir->i_mtime;
> +	dir->i_mtime = inode_set_ctime_current(dir);
>  }
>  
>  static int bpf_mkdir(struct mnt_idmap *idmap, struct inode *dir,
> -- 
> 2.41.0
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux