> -----Original Message----- > From: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx> > Sent: Tuesday, 4 July 2023 17:37 > To: Sriram Yagnaraman <sriram.yagnaraman@xxxxxxxx> > Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; bpf@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>; > Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>; David S . Miller > <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub > Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Alexei > Starovoitov <ast@xxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>; > Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; John Fastabend > <john.fastabend@xxxxxxxxx> > Subject: Re: [PATCH 0/4] igb: Add support for AF_XDP zero-copy > > On Tue, Jul 04, 2023 at 11:59:11AM +0200, Sriram Yagnaraman wrote: > > Hi Sriram, > > > Disclaimer: My first patches to Intel drivers, implemented AF_XDP > > zero-copy feature which seemed to be missing for igb. Not sure if it > > was a conscious choice to not spend time implementing this for older > > devices, nevertheless I send them to the list for review. > > > > The first couple of patches adds helper funcctions to prepare for > > AF_XDP zero-copy support which comes in the last couple of patches, > > one each for Rx and TX paths. > > please include perf numbers in cover letter, CC AF_XDP maintainers and use > batch XSK APIs: xsk_buff_alloc_batch(), xsk_tx_peek_release_desc_batch(). > > Thanks! > Thank you so much for the quick reply. I will respin addressing your comments. For the perf numbers, I must confess, I only used the newly delivered IGB device emulation in qemu. I don't have access to a real NIC to provide realistic numbers. But of course, I can provide a comparison between XSK_COPY and XSK_ZEROCOPY using the emulator. > > > > Sriram Yagnaraman (4): > > igb: prepare for AF_XDP zero-copy support > > igb: Introduce txrx ring enable/disable functions > > igb: add AF_XDP zero-copy Rx support > > igb: add AF_XDP zero-copy Tx support > > > > drivers/net/ethernet/intel/igb/Makefile | 2 +- > > drivers/net/ethernet/intel/igb/igb.h | 52 ++- > > drivers/net/ethernet/intel/igb/igb_main.c | 178 +++++++-- > > drivers/net/ethernet/intel/igb/igb_xsk.c | 434 ++++++++++++++++++++++ > > 4 files changed, 633 insertions(+), 33 deletions(-) create mode > > 100644 drivers/net/ethernet/intel/igb/igb_xsk.c > > > > -- > > 2.34.1 > > > >
