On Sun, Jun 25, 2023 at 10:17:15AM +0800, Heng Qi wrote: > > > 在 2023/6/25 上午3:28, Simon Horman 写道: > > On Sat, Jun 24, 2023 at 08:26:02PM +0800, Heng Qi wrote: > > > > ... > > > > > +static int virtnet_set_csum_after_xdp(struct virtnet_info *vi, > > > + struct sk_buff *skb, > > > + __u8 flags) > > Hi Heng Qi, > > > > Unfortunately this appears to break an x86_64 allmodconfig build > > with GCC 12.3.0: > > > > drivers/net/virtio_net.c:1671:12: error: 'virtnet_set_csum_after_xdp' defined but not used [-Werror=unused-function] > > I admit that this is a patch set, you can cherry-pick patches [1/3] and > [2/3] together > to make it compile without 'defined but not used' warning. If people don't > want to > separate [1/3] and [2/3], I can squash them into one. :) > > Thanks. the answer is yes, do not break the build. > > 1671 | static int virtnet_set_csum_after_xdp(struct virtnet_info *vi, > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > -- > > pw-bot: changes-requested