On Mon, Jun 12, 2023 at 11:49:57AM +0200, Simon Horman wrote: > On Sat, Jun 10, 2023 at 12:58:31AM +0000, Bobby Eshleman wrote: > > This commit makes the bind table management functions in vsock usable > > for different bind tables. For use by datagrams in a future patch. > > > > Signed-off-by: Bobby Eshleman <bobby.eshleman@xxxxxxxxxxxxx> > > --- > > net/vmw_vsock/af_vsock.c | 33 ++++++++++++++++++++++++++------- > > 1 file changed, 26 insertions(+), 7 deletions(-) > > > > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c > > index ef86765f3765..7a3ca4270446 100644 > > --- a/net/vmw_vsock/af_vsock.c > > +++ b/net/vmw_vsock/af_vsock.c > > @@ -230,11 +230,12 @@ static void __vsock_remove_connected(struct vsock_sock *vsk) > > sock_put(&vsk->sk); > > } > > > > -static struct sock *__vsock_find_bound_socket(struct sockaddr_vm *addr) > > +struct sock *vsock_find_bound_socket_common(struct sockaddr_vm *addr, > > + struct list_head *bind_table) > > Hi Bobby, > > This function seems to only be used in this file. > Should it be static? Oh good call, yep. Thanks! Bobby