On Thu, Jun 22, 2023 at 5:07 AM Jesper D. Brouer <netdev@xxxxxxxxxx> wrote: > > > > On 21/06/2023 19.02, Stanislav Fomichev wrote: > > Two kfuncs, one per hook point: > > > > 1. at submit time - bpf_devtx_sb_request_timestamp - to request HW > > to put TX timestamp into TX completion descriptors > > > > 2. at completion time - bpf_devtx_cp_timestamp - to read out > > TX timestamp > > > [...] > > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index 08fbd4622ccf..2fdb0731eb67 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > [...] > > struct xdp_metadata_ops { > > int (*xmo_rx_timestamp)(const struct xdp_md *ctx, u64 *timestamp); > > int (*xmo_rx_hash)(const struct xdp_md *ctx, u32 *hash, > > enum xdp_rss_hash_type *rss_type); > > + int (*xmo_sb_request_timestamp)(const struct devtx_frame *ctx); > > + int (*xmo_cp_timestamp)(const struct devtx_frame *ctx, u64 *timestamp); > > }; > > The "sb" and "cp" abbreviations, what do they stand for? SuBmit and ComPlete. Should I spell them out? Or any other suitable abbreviation?