On Tue, Jun 13, 2023 at 9:41 PM Quentin Monnet <quentin@xxxxxxxxxxxxx> wrote:
>
> 2023-06-12 15:16 UTC+0000 ~ Yafang Shao <laoar.shao@xxxxxxxxx>
> > Show the already expose kprobe_multi link info in bpftool. The result as
> > follows,
> >
> > 52: kprobe_multi prog 381
> > retprobe 0 func_cnt 7
> > addrs ffffffff9ec44f20 funcs schedule_timeout_interruptible
> > ffffffff9ec44f60 schedule_timeout_killable
> > ffffffff9ec44fa0 schedule_timeout_uninterruptible
> > ffffffff9ec44fe0 schedule_timeout_idle
> > ffffffffc09468d0 xfs_trans_get_efd [xfs]
> > ffffffffc0953a10 xfs_trans_get_buf_map [xfs]
> > ffffffffc0957320 xfs_trans_get_dqtrx [xfs]
> > pids kprobe_multi(559862)
> > 53: kprobe_multi prog 381
> > retprobe 1 func_cnt 7
> > addrs ffffffff9ec44f20 funcs schedule_timeout_interruptible
> > ffffffff9ec44f60 schedule_timeout_killable
> > ffffffff9ec44fa0 schedule_timeout_uninterruptible
> > ffffffff9ec44fe0 schedule_timeout_idle
> > ffffffffc09468d0 xfs_trans_get_efd [xfs]
> > ffffffffc0953a10 xfs_trans_get_buf_map [xfs]
> > ffffffffc0957320 xfs_trans_get_dqtrx [xfs]
> > pids kprobe_multi(559862)
> >
> > $ tools/bpf/bpftool/bpftool link show -j
> > [{"id":52,"type":"kprobe_multi","prog_id":381,"retprobe":0,"func_cnt":7,"funcs":[{"addr":18446744072078249760,"func":"schedule_timeout_interruptible","module":""},{"addr":18446744072078249824,"func":"schedule_timeout_killable","module":""},{"addr":18446744072078249888,"func":"schedule_timeout_uninterruptible","module":""},{"addr":18446744072078249952,"func":"schedule_timeout_idle","module":""},{"addr":18446744072645535952,"func":"xfs_trans_get_efd","module":"[xfs]"},{"addr":18446744072645589520,"func":"xfs_trans_get_buf_map","module":"[xfs]"},{"addr":18446744072645604128,"func":"xfs_trans_get_dqtrx","module":"[xfs]"}],"pids":[{"pid":559862,"comm":"kprobe_multi"}]},{"id":53,"type":"kprobe_multi","prog_id":381,"retprobe":1,"func_cnt":7,"funcs":[{"addr":18446744072078249760,"func":"schedule_timeout_interruptible","module":""},{"addr":18446744072078249824,"func":"schedule_timeout_killable","module":""},{"addr":18446744072078249888,"func":"schedule_timeout_uninterruptible","module":""},{"addr":18446744072078249952,"func":"schedule_timeout_idle","module":""},{"addr":18446744072645535952,"func":"xfs_trans_get_efd","module":"[xfs]"},{"addr":18446744072645589520,"func":"xfs_trans_get_buf_map","module":"[xfs]"},{"addr":18446744072645604128,"func":"xfs_trans_get_dqtrx","module":"[xfs]"}],"pids":[{"pid":559862,"comm":"kprobe_multi"}]}]
> >
> > Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>
> > ---
> > tools/bpf/bpftool/link.c | 109 ++++++++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 108 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/bpf/bpftool/link.c b/tools/bpf/bpftool/link.c
> > index 2d78607..0015582 100644
> > --- a/tools/bpf/bpftool/link.c
> > +++ b/tools/bpf/bpftool/link.c
> > @@ -14,8 +14,10 @@
> >
> > #include "json_writer.h"
> > #include "main.h"
> > +#include "xlated_dumper.h"
> >
> > static struct hashmap *link_table;
> > +static struct dump_data dd = {};
> >
> > static int link_parse_fd(int *argc, char ***argv)
> > {
> > @@ -166,6 +168,45 @@ static int get_prog_info(int prog_id, struct bpf_prog_info *info)
> > return err;
> > }
> >
> > +static int cmp_u64(const void *A, const void *B)
> > +{
> > + const __u64 *a = A, *b = B;
> > +
> > + return *a - *b;
> > +}
> > +
> > +static void
> > +show_kprobe_multi_json(struct bpf_link_info *info, json_writer_t *wtr)
> > +{
> > + __u32 i, j = 0;
> > + __u64 *addrs;
> > +
> > + jsonw_uint_field(json_wtr, "retprobe",
> > + info->kprobe_multi.flags & BPF_F_KPROBE_MULTI_RETURN);
>
> The "retprobe" field could maybe be a boolean rather than an int.
Will change it.
>
> > + jsonw_uint_field(json_wtr, "func_cnt", info->kprobe_multi.count);
> > + jsonw_name(json_wtr, "funcs");
> > + jsonw_start_array(json_wtr);
> > + addrs = (__u64 *)u64_to_ptr(info->kprobe_multi.addrs);
> > + qsort((void *)addrs, info->kprobe_multi.count, sizeof(__u64), cmp_u64);
> > +
> > + /* Load it once for all. */
> > + if (!dd.sym_count)
> > + kernel_syms_load(&dd);
> > + for (i = 0; i < dd.sym_count; i++) {
> > + if (dd.sym_mapping[i].address != addrs[j])
> > + continue;
> > + jsonw_start_object(json_wtr);
> > + jsonw_uint_field(json_wtr, "addr", dd.sym_mapping[i].address);
> > + jsonw_string_field(json_wtr, "func", dd.sym_mapping[i].name);
> > + /* Print none if it is vmlinux */
> > + jsonw_string_field(json_wtr, "module", dd.sym_mapping[i].module);
>
> Can we trim the square brackets around module names for the JSON output,
> please? They make entries look like arrays; but mostly, if we keep them,
> we're forcing every consumer to trim them on their side before being
> able to reuse the value.
Agree, will trim it.
--
Regards
Yafang
