Attach kfuncs that request and report TX timestamp via ringbuf.
Confirm on the userspace side that the program has triggered
and the timestamp is non-zero.
Also make sure devtx_frame has a sensible pointers and data.
Cc: netdev@xxxxxxxxxxxxxxx
Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
---
.../selftests/bpf/prog_tests/xdp_metadata.c | 82 +++++++++++++-
.../selftests/bpf/progs/xdp_metadata.c | 101 ++++++++++++++++++
tools/testing/selftests/bpf/xdp_metadata.h | 13 +++
3 files changed, 194 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_metadata.c b/tools/testing/selftests/bpf/prog_tests/xdp_metadata.c
index 626c461fa34d..ebaa50293f85 100644
--- a/tools/testing/selftests/bpf/prog_tests/xdp_metadata.c
+++ b/tools/testing/selftests/bpf/prog_tests/xdp_metadata.c
@@ -42,6 +42,9 @@ struct xsk {
struct xsk_ring_prod tx;
struct xsk_ring_cons rx;
struct xsk_socket *socket;
+ int tx_completions;
+ u32 last_tx_timestamp_retval;
+ u64 last_tx_timestamp;
};
static int open_xsk(int ifindex, struct xsk *xsk)
@@ -192,7 +195,8 @@ static int generate_packet(struct xsk *xsk, __u16 dst_port)
return 0;
}
-static void complete_tx(struct xsk *xsk)
+static void complete_tx(struct xsk *xsk, struct xdp_metadata *bpf_obj,
+ struct ring_buffer *ringbuf)
{
__u32 idx;
__u64 addr;
@@ -202,6 +206,13 @@ static void complete_tx(struct xsk *xsk)
printf("%p: complete tx idx=%u addr=%llx\n", xsk, idx, addr);
xsk_ring_cons__release(&xsk->comp, 1);
+
+ ring_buffer__poll(ringbuf, 1000);
+
+ ASSERT_EQ(bpf_obj->bss->pkts_fail_tx, 0, "pkts_fail_tx");
+ ASSERT_GE(xsk->tx_completions, 1, "tx_completions");
+ ASSERT_EQ(xsk->last_tx_timestamp_retval, 0, "last_tx_timestamp_retval");
+ ASSERT_GE(xsk->last_tx_timestamp, 0, "last_tx_timestamp");
}
}
@@ -276,8 +287,24 @@ static int verify_xsk_metadata(struct xsk *xsk)
return 0;
}
+static int process_sample(void *ctx, void *data, size_t len)
+{
+ struct devtx_sample *sample = data;
+ struct xsk *xsk = ctx;
+
+ printf("%p: got tx timestamp sample %u %llu\n",
+ xsk, sample->timestamp_retval, sample->timestamp);
+
+ xsk->tx_completions++;
+ xsk->last_tx_timestamp_retval = sample->timestamp_retval;
+ xsk->last_tx_timestamp = sample->timestamp;
+
+ return 0;
+}
+
void test_xdp_metadata(void)
{
+ struct ring_buffer *tx_compl_ringbuf = NULL;
struct xdp_metadata2 *bpf_obj2 = NULL;
struct xdp_metadata *bpf_obj = NULL;
struct bpf_program *new_prog, *prog;
@@ -290,6 +317,7 @@ void test_xdp_metadata(void)
int retries = 10;
int rx_ifindex;
int tx_ifindex;
+ int syscall_fd;
int sock_fd;
int ret;
@@ -323,6 +351,16 @@ void test_xdp_metadata(void)
if (!ASSERT_OK_PTR(bpf_obj, "open skeleton"))
goto out;
+ prog = bpf_object__find_program_by_name(bpf_obj->obj, "devtx_sb");
+ bpf_program__set_ifindex(prog, tx_ifindex);
+ bpf_program__set_flags(prog, BPF_F_XDP_DEV_BOUND_ONLY);
+ bpf_program__set_autoattach(prog, false);
+
+ prog = bpf_object__find_program_by_name(bpf_obj->obj, "devtx_cp");
+ bpf_program__set_ifindex(prog, tx_ifindex);
+ bpf_program__set_flags(prog, BPF_F_XDP_DEV_BOUND_ONLY);
+ bpf_program__set_autoattach(prog, false);
+
prog = bpf_object__find_program_by_name(bpf_obj->obj, "rx");
bpf_program__set_ifindex(prog, rx_ifindex);
bpf_program__set_flags(prog, BPF_F_XDP_DEV_BOUND_ONLY);
@@ -330,6 +368,15 @@ void test_xdp_metadata(void)
if (!ASSERT_OK(xdp_metadata__load(bpf_obj), "load skeleton"))
goto out;
+ ret = xdp_metadata__attach(bpf_obj);
+ if (!ASSERT_OK(ret, "xdp_metadata__attach"))
+ goto out;
+
+ tx_compl_ringbuf = ring_buffer__new(bpf_map__fd(bpf_obj->maps.tx_compl_buf),
+ process_sample, &tx_xsk, NULL);
+ if (!ASSERT_OK_PTR(tx_compl_ringbuf, "ring_buffer__new"))
+ goto out;
+
/* Make sure we can't add dev-bound programs to prog maps. */
prog_arr = bpf_object__find_map_by_name(bpf_obj->obj, "prog_arr");
if (!ASSERT_OK_PTR(prog_arr, "no prog_arr map"))
@@ -341,6 +388,26 @@ void test_xdp_metadata(void)
"update prog_arr"))
goto out;
+ /* Attach egress BPF programs to interface. */
+ struct devtx_attach_args args = {
+ .ifindex = tx_ifindex,
+ .devtx_sb_prog_fd = bpf_program__fd(bpf_obj->progs.devtx_sb),
+ .devtx_cp_prog_fd = bpf_program__fd(bpf_obj->progs.devtx_cp),
+ .devtx_sb_retval = -1,
+ .devtx_cp_retval = -1,
+ };
+ DECLARE_LIBBPF_OPTS(bpf_test_run_opts, tattr,
+ .ctx_in = &args,
+ .ctx_size_in = sizeof(args),
+ );
+
+ syscall_fd = bpf_program__fd(bpf_obj->progs.attach_prog);
+ ret = bpf_prog_test_run_opts(syscall_fd, &tattr);
+ if (!ASSERT_GE(ret, 0, "bpf_prog_test_run_opts(attach_prog)"))
+ goto out;
+ ASSERT_GE(args.devtx_sb_retval, 0, "bpf_prog_test_run_opts(attach_prog) devtx_sb_retval");
+ ASSERT_GE(args.devtx_cp_retval, 0, "bpf_prog_test_run_opts(attach_prog) devtx_cp_retval");
+
/* Attach BPF program to RX interface. */
ret = bpf_xdp_attach(rx_ifindex,
@@ -364,7 +431,16 @@ void test_xdp_metadata(void)
"verify_xsk_metadata"))
goto out;
- complete_tx(&tx_xsk);
+ /* Verify AF_XDP TX packet has completion event with a timestamp. */
+ complete_tx(&tx_xsk, bpf_obj, tx_compl_ringbuf);
+
+ /* Detach egress program. */
+ syscall_fd = bpf_program__fd(bpf_obj->progs.detach_prog);
+ ret = bpf_prog_test_run_opts(syscall_fd, &tattr);
+ if (!ASSERT_GE(ret, 0, "bpf_prog_test_run_opts(detach_prog)"))
+ goto out;
+ ASSERT_GE(args.devtx_sb_retval, 0, "bpf_prog_test_run_opts(detach_prog) devtx_sb_retval");
+ ASSERT_GE(args.devtx_cp_retval, 0, "bpf_prog_test_run_opts(detach_prog) devtx_cp_retval");
/* Make sure freplace correctly picks up original bound device
* and doesn't crash.
@@ -402,5 +478,7 @@ void test_xdp_metadata(void)
xdp_metadata__destroy(bpf_obj);
if (tok)
close_netns(tok);
+ if (tx_compl_ringbuf)
+ ring_buffer__free(tx_compl_ringbuf);
SYS_NOFAIL("ip netns del xdp_metadata");
}
diff --git a/tools/testing/selftests/bpf/progs/xdp_metadata.c b/tools/testing/selftests/bpf/progs/xdp_metadata.c
index d151d406a123..5b815bd03fe7 100644
--- a/tools/testing/selftests/bpf/progs/xdp_metadata.c
+++ b/tools/testing/selftests/bpf/progs/xdp_metadata.c
@@ -4,6 +4,11 @@
#include "xdp_metadata.h"
#include <bpf/bpf_helpers.h>
#include <bpf/bpf_endian.h>
+#include <bpf/bpf_tracing.h>
+
+#ifndef ETH_P_IP
+#define ETH_P_IP 0x0800
+#endif
struct {
__uint(type, BPF_MAP_TYPE_XSKMAP);
@@ -19,10 +24,22 @@ struct {
__type(value, __u32);
} prog_arr SEC(".maps");
+struct {
+ __uint(type, BPF_MAP_TYPE_RINGBUF);
+ __uint(max_entries, 10);
+} tx_compl_buf SEC(".maps");
+
+__u64 pkts_fail_tx = 0;
+
extern int bpf_xdp_metadata_rx_timestamp(const struct xdp_md *ctx,
__u64 *timestamp) __ksym;
extern int bpf_xdp_metadata_rx_hash(const struct xdp_md *ctx, __u32 *hash,
enum xdp_rss_hash_type *rss_type) __ksym;
+extern int bpf_devtx_sb_request_timestamp(const struct devtx_frame *ctx) __ksym;
+extern int bpf_devtx_cp_timestamp(const struct devtx_frame *ctx, __u64 *timestamp) __ksym;
+
+extern int bpf_devtx_sb_attach(int ifindex, int prog_fd) __ksym;
+extern int bpf_devtx_cp_attach(int ifindex, int prog_fd) __ksym;
SEC("xdp")
int rx(struct xdp_md *ctx)
@@ -61,4 +78,88 @@ int rx(struct xdp_md *ctx)
return bpf_redirect_map(&xsk, ctx->rx_queue_index, XDP_PASS);
}
+static inline int verify_frame(const struct devtx_frame *frame)
+{
+ struct ethhdr eth = {};
+
+ /* all the pointers are set up correctly */
+ if (!frame->data)
+ return -1;
+ if (!frame->sinfo)
+ return -1;
+
+ /* can get to the frags */
+ if (frame->sinfo->nr_frags != 0)
+ return -1;
+ if (frame->sinfo->frags[0].bv_page != 0)
+ return -1;
+ if (frame->sinfo->frags[0].bv_len != 0)
+ return -1;
+ if (frame->sinfo->frags[0].bv_offset != 0)
+ return -1;
+
+ /* the data has something that looks like ethernet */
+ if (frame->len != 46)
+ return -1;
+ bpf_probe_read_kernel(ð, sizeof(eth), frame->data);
+
+ if (eth.h_proto != bpf_htons(ETH_P_IP))
+ return -1;
+
+ return 0;
+}
+
+SEC("fentry/devtx_sb")
+int BPF_PROG(devtx_sb, const struct devtx_frame *frame)
+{
+ int ret;
+
+ ret = verify_frame(frame);
+ if (ret < 0)
+ __sync_add_and_fetch(&pkts_fail_tx, 1);
+
+ ret = bpf_devtx_sb_request_timestamp(frame);
+ if (ret < 0)
+ __sync_add_and_fetch(&pkts_fail_tx, 1);
+
+ return 0;
+}
+
+SEC("fentry/devtx_cp")
+int BPF_PROG(devtx_cp, const struct devtx_frame *frame)
+{
+ struct devtx_sample *sample;
+ int ret;
+
+ ret = verify_frame(frame);
+ if (ret < 0)
+ __sync_add_and_fetch(&pkts_fail_tx, 1);
+
+ sample = bpf_ringbuf_reserve(&tx_compl_buf, sizeof(*sample), 0);
+ if (!sample)
+ return 0;
+
+ sample->timestamp_retval = bpf_devtx_cp_timestamp(frame, &sample->timestamp);
+
+ bpf_ringbuf_submit(sample, 0);
+
+ return 0;
+}
+
+SEC("syscall")
+int attach_prog(struct devtx_attach_args *ctx)
+{
+ ctx->devtx_sb_retval = bpf_devtx_sb_attach(ctx->ifindex, ctx->devtx_sb_prog_fd);
+ ctx->devtx_cp_retval = bpf_devtx_cp_attach(ctx->ifindex, ctx->devtx_cp_prog_fd);
+ return 0;
+}
+
+SEC("syscall")
+int detach_prog(struct devtx_attach_args *ctx)
+{
+ ctx->devtx_sb_retval = bpf_devtx_sb_attach(ctx->ifindex, -1);
+ ctx->devtx_cp_retval = bpf_devtx_cp_attach(ctx->ifindex, -1);
+ return 0;
+}
+
char _license[] SEC("license") = "GPL";
diff --git a/tools/testing/selftests/bpf/xdp_metadata.h b/tools/testing/selftests/bpf/xdp_metadata.h
index 938a729bd307..add900c9035c 100644
--- a/tools/testing/selftests/bpf/xdp_metadata.h
+++ b/tools/testing/selftests/bpf/xdp_metadata.h
@@ -18,3 +18,16 @@ struct xdp_meta {
__s32 rx_hash_err;
};
};
+
+struct devtx_sample {
+ int timestamp_retval;
+ __u64 timestamp;
+};
+
+struct devtx_attach_args {
+ int ifindex;
+ int devtx_sb_prog_fd;
+ int devtx_cp_prog_fd;
+ int devtx_sb_retval;
+ int devtx_cp_retval;
+};
--
2.41.0.162.gfafddb0af9-goog
