On Thu, Jun 08, 2023 at 09:36:39PM -0700, Song Liu wrote: > On Thu, Jun 8, 2023 at 4:14 PM Andrii Nakryiko > <andrii.nakryiko@xxxxxxxxx> wrote: > > > > On Thu, Jun 8, 2023 at 3:35 AM Yafang Shao <laoar.shao@xxxxxxxxx> wrote: > > > > > > Add libbpf API to get generic perf event name. > > > > > > Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx> > > > --- > > > > I don't think this belongs in libbpf and shouldn't be exposed as > > public API. Please move it into bpftool and make it internal (if > > Quentin is fine with this in the first place). > > Or maybe it belongs to libperf? we have several lookup arrays like that in perf and we keep also 'alias' names.. it'd be good idea to have that only in libperf, but that would require perf perf's parse-events cleanup as well and bpftool starting to link libperf I'd keep it in bpftool for now and have that cleanup later cc-ing Arnaldo jirka > > Thanks, > Song