Re: [PATCH v2 bpf-next 04/11] bpf: Protect probed address based on kptr_restrict setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 9, 2023 at 7:09 AM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> On Thu, Jun 8, 2023 at 3:35 AM Yafang Shao <laoar.shao@xxxxxxxxx> wrote:
> >
> > The probed address can be accessed by userspace through querying the task
> > file descriptor (fd). However, it is crucial to adhere to the kptr_restrict
> > setting and refrain from exposing the address if it is not permitted.
> >
> > Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>
> > ---
> >  kernel/trace/trace_kprobe.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> > index 59cda19..6564541 100644
> > --- a/kernel/trace/trace_kprobe.c
> > +++ b/kernel/trace/trace_kprobe.c
> > @@ -1551,7 +1551,10 @@ int bpf_get_kprobe_info(const struct perf_event *event, u32 *fd_type,
> >         } else {
> >                 *symbol = NULL;
> >                 *probe_offset = 0;
> > -               *probe_addr = (unsigned long)tk->rp.kp.addr;
> > +               if (kptr_restrict != 2)
> > +                       *probe_addr = (unsigned long)tk->rp.kp.addr;
> > +               else
> > +                       *probe_addr = 0;
>
> kallsyms_show_value ?

Will change it.

-- 
Regards
Yafang





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux