Re: [PATCH v3] Documentation: subsystem-apis: Categorize remaining subsystems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 01, 2023 at 05:55:55PM +0300, Costa Shulyupin wrote:
> From: Bagas Sanjaya <bagasdotme@xxxxxxxxx>
> 
> Add classes:
> * Core subsystems
> * Storage
> * Networking
> * Peripherals and devices
> * Embedded systems
> * Integrity
> * Virtualization
> * Miscellaneous

Above list is unnecessary, because the diff should clearly show those
categories.

> 
> There is a FIXME that says to organize subsystems listed in
> subsystem-apis.rst. Fulfill it by categorize remaining subsytems
> by purpose/themes, while sorting entries in each category.
> 
> HID devices are already categorized in 3c591cc954d56e ("docs:
> consolidate human interface subsystems").
> 
> Signed-off-by: Costa Shulyupin <costa.shul@xxxxxxxxxx>

Thanks for picking my version from v2 [1]. However, From: address in the
patch message doesn't match one from message header nor your Signed-off-by
address. Conversely, if you handle someone else's patch (in this case mine),
you need to also add SoB from him/her.

As you're still newbie here, I'd recommend you to try contributing to
drivers/staging/ first in order to gain experience on kernel developement
workflow. Also, you use your RedHat address, so I expect you have been
given kernel development training from your company (and doesn't make
trivial errors like these ones).

Anyway, I'd like to send my own version instead (incorporating feedback
from this version) if you still reroll with trivial sending mistakes.

Thanks.

[1]: https://lore.kernel.org/linux-doc/ZHgM0qKWP3OusjUW@xxxxxxxxx/
 
-- 
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux