On Wed, May 17, 2023 at 4:01 PM Beau Belgrave <beaub@xxxxxxxxxxxxxxxxxxx> wrote:
>
> Do you mind giving me your Signed-off-by for these?
Assuming you have some test-cases that you've run them through, then yes:
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
for both. But since I can't really test them myself, I'd really like
that. I did these patches just by looking at the source code, and
while I think that's an excellent way to do development, I do think
that testing is _also_ required.
And that second patch was obviously not even build-tested, so really
just a "something like this".
> I plan to do a series where I take these patches and then also fix up a
> few comments and the link namings as you suggested.
Sounds good.
> First patch is clean, second patch I made the following changes and
> after that passed all the self-tests without bug splats with
> CONFIG_PROVE_LOCKING/RCU and ATOMIC_SLEEP:
Your suggested version with just "list_add()" and a comment about why
it doesn't need RCU safety looks good. And the build fix obviously
requited ;)
Linus
