On Tue, May 16, 2023 at 2:45 PM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Mon, May 15, 2023 at 6:39 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > > > > Currently the test_verifier allows test to specify kfunc symbol > > and search for it in the kernel BTF. > > > > Adding the possibility to search for kfunc also in bpf_testmod > > module when it's not found in kernel BTF. > > > > To find bpf_testmod btf we need to get back SYS_ADMIN cap. > > > > Acked-by: David Vernet <void@xxxxxxxxxxxxx> > > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx> > > --- > > tools/testing/selftests/bpf/test_verifier.c | 161 +++++++++++++++++--- > > 1 file changed, 139 insertions(+), 22 deletions(-) > > > > Eduard is working on migrating most (if not all) test_verifier tests > into test_progs where we can use libbpf declarative functionality for > things like this. > > Eduard, can you please review this part? Would it make sense to just > wait for the migration? No. Migration might never complete. It's already at the point of diminishing returns. This patch set is a great clean up on its own. Hence I've decided to apply it. If in the future this particular patch for test_verifier won't be necessary we can easily revert it.
