On 2023/5/9 4:45, Lorenzo Bianconi wrote:
> Since veth_convert_skb_to_xdp_buff routine runs in veth_poll() NAPI,
> rely on napi_build_skb() instead of build_skb() to reduce skb allocation
> cost.
LGTM.
Reviewed-by: Yunsheng Lin <linyunsheng@xxxxxxxxxx>
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> ---
> drivers/net/veth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index dce9f9d63e04..3ae496011640 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -747,7 +747,7 @@ static int veth_convert_skb_to_xdp_buff(struct veth_rq *rq,
> if (!page)
> goto drop;
>
> - nskb = build_skb(page_address(page), PAGE_SIZE);
> + nskb = napi_build_skb(page_address(page), PAGE_SIZE);
> if (!nskb) {
> page_pool_put_full_page(rq->page_pool, page, true);
> goto drop;
>
