Re: [PATCH bpf v7 13/13] bpf: sockmap, test FIONREAD returns correct bytes in rx buffer with drops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 02, 2023 at 08:51 AM -07, John Fastabend wrote:
> When BPF program drops pkts the sockmap logic 'eats' the packet and
> updates copied_seq. In the PASS case where the sk_buff is accepted
> we update copied_seq from recvmsg path so we need a new test to
> handle the drop case.
>
> Original patch series broke this resulting in
>
> test_sockmap_skb_verdict_fionread:PASS:ioctl(FIONREAD) error 0 nsec
> test_sockmap_skb_verdict_fionread:FAIL:ioctl(FIONREAD) unexpected ioctl(FIONREAD): actual 1503041772 != expected 256
> #176/17  sockmap_basic/sockmap skb_verdict fionread on drop:FAIL
>
> After updated patch with fix.
>
> #176/16  sockmap_basic/sockmap skb_verdict fionread:OK
> #176/17  sockmap_basic/sockmap skb_verdict fionread on drop:OK
>
> Signed-off-by: John Fastabend <john.fastabend@xxxxxxxxx>
> ---

Reviewed-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux