On Thu, May 4, 2023 at 9:04 AM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Tue, Apr 25, 2023 at 04:49:07PM -0700, Andrii Nakryiko wrote: > > + > > + err = mark_chain_precision_batch(env, old->curframe); > > I think I'm sort-of starting to get it, but > above should be env->cur_state->curframe instead of old->curframe, no? > mark_chain_precision_batch will be using branch history of current frame. > __mark_chain_precision() always operates on > struct bpf_verifier_state *st = env->cur_state; wait. patch 5 made __mark_chain_precision() to ignore 'frame' argument. Why did you keep it in mark_chain_precision_batch() and pass it here?