On Wed, Apr 26, 2023 at 12:11:41PM -0700, Andrii Nakryiko wrote: > On Mon, Apr 24, 2023 at 9:05 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > > > > Adding support for bpf_get_func_ip helper being called from > > ebpf program attached by uprobe_multi link. > > > > It returns the ip of the uprobe. > > > > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx> > > --- > > LGTM. I assume that IP will be user space address for uprobes, right? > Might be worth calling this out explicitly (it's kind of obvious and > expected, though, so maybe I'm overthinking this). yes, it's user space address where the probe is attached, I'll make it more obvious ;-) thanks, jirka > > Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > > > kernel/trace/bpf_trace.c | 33 ++++++++++++++++++++++++++++++--- > > 1 file changed, 30 insertions(+), 3 deletions(-) > > > > [...]
