On Fri, 2023-04-21 at 12:48 -0700, Alexei Starovoitov wrote: > On Fri, Apr 21, 2023 at 10:42 AM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote: > > > > This is a follow up for RFC [1]. It migrates a second batch of 23 > > verifier/*.c tests to inline assembly and use of ./test_progs for > > actual execution. Link to the first batch is [2]. > > > > The migration is done by a python script (see [3]) with minimal manual > > adjustments. > > All makes sense to me. > Took 22 out of 24 patches. > The 13 and 14 had conflicts. > Also there is a precision fix in bpf tree. > So we're going to wait for bpf/bpf-next to converge during > the merge window next week, then add another precision test as asm > and then regenerate conversion of the precision tests. > Not sure why 14 was conflicting. Oh, understood, thank you. The #14 does not apply because it also starts from 'p', so the hunk below does not match: --- tools/testing/selftests/bpf/prog_tests/verifier.c +++ tools/testing/selftests/bpf/prog_tests/verifier.c @@ -41,6 +41,7 @@ #include "verifier_masking.skel.h" #include "verifier_meta_access.skel.h" #include "verifier_precise.skel.h" +#include "verifier_prevent_map_lookup.skel.h" #include "verifier_raw_stack.skel.h" #include "verifier_raw_tp_writable.skel.h" #include "verifier_reg_equal.skel.h" I will resend it shortly.