On Wed, Apr 19, 2023 at 1:08 PM kernel test robot <lkp@xxxxxxxxx> wrote: > > Hi Stanislav, > > kernel test robot noticed the following build warnings: Stupid me using ``` blocks instead of code-block:: c. Will address once I hear some feedback on the rest of the patches. > [auto build test WARNING on bpf-next/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/bpf-Don-t-EFAULT-for-getsockopt-with-optval-NULL/20230419-065442 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > patch link: https://lore.kernel.org/r/20230418225343.553806-7-sdf%40google.com > patch subject: [PATCH bpf-next 6/6] bpf: Document EFAULT changes for sockopt > reproduce: > # https://github.com/intel-lab-lkp/linux/commit/789f0fbf25934464ae56e0022939fc77d4615d65 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Stanislav-Fomichev/bpf-Don-t-EFAULT-for-getsockopt-with-optval-NULL/20230419-065442 > git checkout 789f0fbf25934464ae56e0022939fc77d4615d65 > make menuconfig > # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS > make htmldocs > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Link: https://lore.kernel.org/oe-kbuild-all/202304200301.XukL6sTb-lkp@xxxxxxxxx/ > > All warnings (new ones prefixed by >>): > > >> Documentation/bpf/prog_cgroup_sockopt.rst:115: WARNING: Unexpected indentation. > >> Documentation/bpf/prog_cgroup_sockopt.rst:111: WARNING: Inline literal start-string without end-string. > >> Documentation/bpf/prog_cgroup_sockopt.rst:111: WARNING: Inline emphasis start-string without end-string. > >> Documentation/bpf/prog_cgroup_sockopt.rst:121: WARNING: Block quote ends without a blank line; unexpected unindent. > >> Documentation/bpf/prog_cgroup_sockopt.rst:159: WARNING: Title level inconsistent: > > vim +115 Documentation/bpf/prog_cgroup_sockopt.rst > > 110 > > 111 ``` > 112 SEC("cgroup/getsockopt") > 113 int getsockopt(struct bpf_sockopt *ctx) > 114 { > > 115 /* Custom socket option. */ > 116 if (ctx->level == MY_SOL && ctx->optname == MY_OPTNAME) { > 117 ctx->retval = 0; > 118 optval[0] = ...; > 119 ctx->optlen = 1; > 120 return 1; > > 121 } > 122 > 123 /* Modify kernel's socket option. */ > 124 if (ctx->level == SOL_IP && ctx->optname == IP_FREEBIND) { > 125 ctx->retval = 0; > 126 optval[0] = ...; > 127 ctx->optlen = 1; > 128 return 1; > 129 } > 130 > 131 /* optval larger than PAGE_SIZE use kernel's buffer. */ > 132 if (ctx->optlen > 4096) > 133 ctx->optlen = 0; > 134 > 135 return 1; > 136 } > 137 > 138 SEC("cgroup/setsockopt") > 139 int setsockopt(struct bpf_sockopt *ctx) > 140 { > 141 /* Custom socket option. */ > 142 if (ctx->level == MY_SOL && ctx->optname == MY_OPTNAME) { > 143 /* do something */ > 144 ctx->optlen = -1; > 145 return 1; > 146 } > 147 > 148 /* Modify kernel's socket option. */ > 149 if (ctx->level == SOL_IP && ctx->optname == IP_FREEBIND) { > 150 optval[0] = ...; > 151 return 1; > 152 } > 153 > 154 /* optval larger than PAGE_SIZE use kernel's buffer. */ > 155 if (ctx->optlen > 4096) > 156 ctx->optlen = 0; > 157 > 158 return 1; > > 159 } > 160 ``` > 161 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests
