Re: [PATCH] bpftool: fix broken compile on s390 for linux-next repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 19 Apr 2023 at 15:51, Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
>
> On 4/18/23 10:55 AM, Thomas Richter wrote:

> > -                     __fallthrough;
> > +                     fallthrough;
>
> The problem is however for current bpf-next, where this change breaks CI:
>
> https://github.com/kernel-patches/bpf/actions/runs/4737651765/jobs/8410684531
>
>    [...]
>      CC      /tmp/work/bpf/bpf/tools/testing/selftests/bpf/tools/build/bpftool/feature.o
>      CC      /tmp/work/bpf/bpf/tools/testing/selftests/bpf/tools/build/bpftool/disasm.o
>    btf_dumper.c:838:4: error: use of undeclared identifier 'fallthrough'
>                            fallthrough;
>                            ^
>    1 error generated.
>    [...]
>
> I would suggest as a clean path that'll work for both to just change from
> fallthrough; into /* fallthrough */ as done in objtool, then we can also
> work around BPF CI issue and merge this change in time.
>
> >               default:
> >                       putchar(*s);
> >               }
> >
>

Thanks Daniel for pointing this out. I just submitted the patch you suggested:
https://lore.kernel.org/bpf/20230420003333.90901-1-quentin@xxxxxxxxxxxxx/

Quentin



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux