Re: [PATCH bpf-next v2 2/2] bpftool: Update doc to explain struct_ops register subcommand.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 19 Apr 2023 at 03:56, Kui-Feng Lee <thinker.li@xxxxxxxxx> wrote:
>
> The "struct_ops register" subcommand now allows for an optional *LINK_DIR*
> to be included. This specifies the directory path where bpftool will pin
> struct_ops links with the same name as their corresponding map names.
>
> Signed-off-by: Kui-Feng Lee <kuifeng@xxxxxxxx>
> ---
>  tools/bpf/bpftool/Documentation/bpftool-struct_ops.rst | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tools/bpf/bpftool/Documentation/bpftool-struct_ops.rst b/tools/bpf/bpftool/Documentation/bpftool-struct_ops.rst
> index ee53a122c0c7..2111c9550938 100644
> --- a/tools/bpf/bpftool/Documentation/bpftool-struct_ops.rst
> +++ b/tools/bpf/bpftool/Documentation/bpftool-struct_ops.rst
> @@ -51,10 +51,14 @@ DESCRIPTION
>                   for the given struct_ops.  Otherwise, it dumps all struct_ops
>                   currently existing in the system.
>
> -       **bpftool struct_ops register** *OBJ*
> +       **bpftool struct_ops register** *OBJ* [*LINK_DIR*]
>                   Register bpf struct_ops from *OBJ*.  All struct_ops under
> -                 the ELF section ".struct_ops" will be registered to
> -                 its kernel subsystem.
> +                 the ELF section ".struct_ops" and ".struct_ops.link" will
> +                 be registered to its kernel subsystem.  For each
> +                 struct_ops in the ".struct_ops.link" section, a link
> +                 will be created.  You can give *LINK_DIR* to provide a
> +                 directory path where these links will be pinned with the
> +                 same name as their corresponding map name.
>
>         **bpftool struct_ops unregister**  *STRUCT_OPS_MAP*
>                   Unregister the *STRUCT_OPS_MAP* from the kernel subsystem.

Thanks! Since there are some nits to address on the first patch
anyway, would you mind updating the command summary earlier in this
file as well, please? In section "STRUCT_OPS COMMANDS".

Thanks,
Quentin



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux