On 4/18/23 14:44, Quentin Monnet wrote:
On Tue, 18 Apr 2023 at 01:29, Kui-Feng Lee <thinker.li@xxxxxxxxx> wrote:
A new link type, BPF_LINK_TYPE_STRUCT_OPS, was added to attach
struct_ops to links. (226bc6ae6405) It would be helpful for users to
know which map is associated with the link.
The assumption was that every link is associated with a BPF program,
but this does not hold true for struct_ops. It would be better to
display map_id instead of prog_id for struct_ops links. However, some
tools may rely on the old assumption and need a prog_id displayed in
the link header line. By keeping the prog_id unchanged, an extra line
indicating the map_id is displayed.
Signed-off-by: Kui-Feng Lee <kuifeng@xxxxxxxx>
Reviewed-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>
Thanks! What does the prog_id correspond to, for this type of links?
If it's not relevant at all we could at least take it out from the
plain output maybe, tools that want to parse the output should stick
to JSON.
The prog_id is irrelevant here. Since our convention is to let tools
parse JSON, I will move map_id to the header line of plain text output
and remove the prog_id, just like you said.
