On Mon, Apr 3, 2023 at 9:50 PM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > From: Alexei Starovoitov <ast@xxxxxxxxxx> > > Remove unused arguments from btf_struct_access() callback. > > Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxx> > --- expected this change in patch #1, tbh, even wrote a comment about dropping enum bpf_access_type, but then guessed to check next patch. Anyways, I'm fine either way, but patch 1 and 2 together make for much less confusing change, IMO. See also my note about renaming *callback* to make its write access nature clear. > include/linux/bpf.h | 3 +-- > include/linux/filter.h | 3 +-- > kernel/bpf/verifier.c | 4 ++-- > net/bpf/bpf_dummy_struct_ops.c | 12 +++++------- > net/core/filter.c | 13 +++++-------- > net/ipv4/bpf_tcp_ca.c | 3 +-- > net/netfilter/nf_conntrack_bpf.c | 3 +-- > 7 files changed, 16 insertions(+), 25 deletions(-) > [...]