Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@xxxxxxxxxx>:
On Mon, 3 Apr 2023 13:00:27 -0700 you wrote:
> bpf_obj_drop_impl has a void return type. In check_kfunc_call, the "else
> if" which sets insn_aux->kptr_struct_meta for bpf_obj_drop_impl is
> surrounded by a larger if statement which checks btf_type_is_ptr. As a
> result:
>
> * The bpf_obj_drop_impl-specific code will never execute
> * The btf_struct_meta input to bpf_obj_drop is always NULL
> * __bpf_obj_drop_impl will always see a NULL btf_record when called
> from BPF program, and won't call bpf_obj_free_fields
> * program-allocated kptrs which have fields that should be cleaned up
> by bpf_obj_free_fields may instead leak resources
>
> [...]
Here is the summary with links:
- [bpf-next] bpf: Fix struct_meta lookup for bpf_obj_free_fields kfunc call
https://git.kernel.org/bpf/bpf-next/c/f6a6a5a97628
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
