Re: [PATCH bpf V5 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Why have this patchset[1] been marked "Changes Requested" ?

Notice: The BPF test_progs are failing on "xdp_do_redirect", but that is
not related to this patchset as it already happens on a clean bpf-tree.


[1] https://patchwork.kernel.org/project/netdevbpf/list/?series=735957&state=%2A


On 31/03/2023 20.54, Jesper Dangaard Brouer wrote:
Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value,
but doesn't provide information on the RSS hash type (part of 6.3-rc).

This patchset proposal is to change the function call signature via adding
a pointer value argument for providing the RSS hash type.

---
V5:
  - Fixes for checkpatch.pl
  - Change function signature for all xmo_rx_hash calls in patch1

Jesper Dangaard Brouer (5):
       xdp: rss hash types representation
       mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type
       veth: bpf_xdp_metadata_rx_hash add xdp rss hash type
       mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type
       selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg


  drivers/net/ethernet/mellanox/mlx4/en_rx.c    | 22 ++++++-
  drivers/net/ethernet/mellanox/mlx4/mlx4_en.h  |  3 +-
  .../net/ethernet/mellanox/mlx5/core/en/xdp.c  | 63 ++++++++++++++++++-
  drivers/net/veth.c                            | 10 ++-
  include/linux/mlx5/device.h                   | 14 ++++-
  include/linux/netdevice.h                     |  3 +-
  include/net/xdp.h                             | 47 ++++++++++++++
  net/core/xdp.c                                | 10 ++-
  .../selftests/bpf/prog_tests/xdp_metadata.c   |  2 +
  .../selftests/bpf/progs/xdp_hw_metadata.c     | 14 +++--
  .../selftests/bpf/progs/xdp_metadata.c        |  6 +-
  .../selftests/bpf/progs/xdp_metadata2.c       |  7 ++-
  tools/testing/selftests/bpf/xdp_hw_metadata.c |  2 +-
  tools/testing/selftests/bpf/xdp_metadata.h    |  1 +
  14 files changed, 180 insertions(+), 24 deletions(-)

--





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux