On Fri, 2023-03-31 at 15:52 +0100, Quentin Monnet wrote:
[...]
> > > @@ -413,6 +414,16 @@ void dump_xlated_for_graph(struct dump_data *dd, void *buf_start, void *buf_end,
> > > printf("%d: ", insn_off);
> > > print_bpf_insn(&cbs, cur, true);
> > >
> > > + if (opcodes) {
> > > + printf(" ");
> >
> > These spaces are treated as a single space by the dot renderer, as [1]
> > says: "Spaces are interpreted as separators between tokens, so they
> > must be escaped if you want spaces in the text."
> >
> > [1] https://graphviz.org/doc/info/shapes.html#record
>
> I noticed, I kept the multiple spaces to make the DOT output slightly
> more readable. But it would maybe make sense to indent more in the graph
> as well, if it doesn't make opcode sequences wider than instructions.
> I'll have a look at this.
Oh, sorry, that did not occur to me, making DOT itself more readable
makes total sense.
