hi, this selftests cleanup was previously posted as part of file build id changes [1], which might take more time, so I'm sending the selftests changes separately so it won't get stuck. v4 changes: - added size argument to read_build_id [Andrii] - condition changes in parse_build_id_buf [Andrii] - use ELF_C_READ_MMAP in elf_begin [Andrii] - return -ENOENT in read_build_id if build id is not found [Andrii] - dropped elf class check [Andrii] thanks, jirka [1] https://lore.kernel.org/bpf/20230316170149.4106586-1-jolsa@xxxxxxxxxx/ --- Jiri Olsa (3): selftests/bpf: Add err.h header selftests/bpf: Add read_build_id function selftests/bpf: Replace extract_build_id with read_build_id tools/testing/selftests/bpf/prog_tests/stacktrace_build_id.c | 19 +++++++------------ tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c | 17 ++++++----------- tools/testing/selftests/bpf/progs/err.h | 18 ++++++++++++++++++ tools/testing/selftests/bpf/progs/profiler.inc.h | 3 +-- tools/testing/selftests/bpf/test_progs.c | 25 ------------------------- tools/testing/selftests/bpf/test_progs.h | 1 - tools/testing/selftests/bpf/trace_helpers.c | 82 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tools/testing/selftests/bpf/trace_helpers.h | 5 +++++ 8 files changed, 119 insertions(+), 51 deletions(-) create mode 100644 tools/testing/selftests/bpf/progs/err.h