On Wed, 29 Mar 2023 21:22:03 -0700, Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > On Tue, 28 Mar 2023 17:28:43 +0800 Xuan Zhuo wrote: > > +const struct net_device_ops *virtnet_get_netdev(void) > > +{ > > + return &virtnet_netdev; > > +} > > Why not just make the virtnet_netdev symbol visible? > Many drivers do that. > > If you prefer the function maybe virtnet_get_ndos() would be a better > name for example? The current name sounds like it will get a... well.. > a netdev. And it gets ops. Will fix. Thanks.