On 28/03/2023 21:15, Jesper Dangaard Brouer wrote: > Hardware RSS types are differently encoded for each hardware NIC. Most > hardware represent RSS hash type as a number. Determining L3 vs L4 often > requires a mapping table as there often isn't a pattern or sorting > according to ISO layer. > > The patch introduce a XDP RSS hash type (xdp_rss_hash_type) that can both > be seen as a number that is ordered according by ISO layer, and can be bit > masked to separate IPv4 and IPv6 types for L4 protocols. Room is available > for extending later while keeping these properties. This maps and unifies > difference to hardware specific hashes. Would it be better to make use of the ETHTOOL_GRXFH defines (stuff like UDP_V6_FLOW, RXH_L4_B_0_1 etc.)? Seems like that could allow for some code reuse in drivers.