On Sat, Mar 25, 2023 at 9:16 AM Stanislav Fomichev <sdf@xxxxxxxxxx> wrote: > > > > > It was my understanding from the RFC feedback that this "lighter" way > > is preferable and we already have some tests written like that. > > Don't have a strong opinion on this topic. > > Ack, I'm obviously losing a bunch of context here :-( > I like coalescing better, but if the original suggestion was to use > this lighter way, I'll keep that in mind while reviewing. I still prefer the clean look of the tests, so I've applied this set. But I'm not going to insist that this is the only style developers should use moving forward. Whoever prefers "" style can use it in the future tests. I find them harder to read, but oh well. Ed, the only small nit I've noticed is that the tests are compiled for both test_progs and test_progs-no_alu32 though they're in asm. So we're wasting a bit of CI time running them in both flavors. Not a big deal and maybe not worth fixing, since they're pretty fast.
