On Tue, Mar 21, 2023 at 1:43 PM Tariq Toukan <ttoukan.linux@xxxxxxxxx> wrote: > > > > On 21/03/2023 15:52, Jesper Dangaard Brouer wrote: > > When driver doesn't implement a bpf_xdp_metadata kfunc the fallback > > implementation returns EOPNOTSUPP, which indicate device driver doesn't > > implement this kfunc. > > > > Currently many drivers also return EOPNOTSUPP when the hint isn't > > available, which is ambiguous from an API point of view. Instead > > change drivers to return ENODATA in these cases. > > > > There can be natural cases why a driver doesn't provide any hardware > > info for a specific hint, even on a frame to frame basis (e.g. PTP). > > Lets keep these cases as separate return codes. > > > > When describing the return values, adjust the function kernel-doc layout > > to get proper rendering for the return values. > > > > Fixes: ab46182d0dcb ("net/mlx4_en: Support RX XDP metadata") > > Fixes: bc8d405b1ba9 ("net/mlx5e: Support RX XDP metadata") > > Fixes: 306531f0249f ("veth: Support RX XDP metadata") > > Fixes: 3d76a4d3d4e5 ("bpf: XDP metadata RX kfuncs") > > Signed-off-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx> > > For the mlx4/5 parts: > Acked-by: Tariq Toukan <tariqt@xxxxxxxxxx> FYI this patch was applied to bpf tree. pw-bot doesn't notice bpf tree anymore :(