Hi Kal, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf/master] [also build test ERROR on next-20230317] [cannot apply to bpf-next/master linus/master v6.3-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kal-Conley/xsk-Support-UMEM-chunk_size-PAGE_SIZE/20230320-035849 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master patch link: https://lore.kernel.org/r/20230319195656.326701-2-kal.conley%40dectris.com patch subject: [PATCH bpf-next 1/3] xsk: Support UMEM chunk_size > PAGE_SIZE config: arm-mvebu_v5_defconfig (https://download.01.org/0day-ci/archive/20230320/202303200837.DNorzOFV-lkp@xxxxxxxxx/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/bbcc35c4ff807754bf61ef2c1f11195533e53de0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Kal-Conley/xsk-Support-UMEM-chunk_size-PAGE_SIZE/20230320-035849 git checkout bbcc35c4ff807754bf61ef2c1f11195533e53de0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash net/core/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303200837.DNorzOFV-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from net/core/xdp.c:22: In file included from include/net/xdp_sock_drv.h:10: >> include/net/xsk_buff_pool.h:179:43: error: use of undeclared identifier 'HPAGE_SIZE' bool cross_pg = pool->hugetlb ? (addr & (HPAGE_SIZE - 1)) + len > HPAGE_SIZE : ^ include/net/xsk_buff_pool.h:179:68: error: use of undeclared identifier 'HPAGE_SIZE' bool cross_pg = pool->hugetlb ? (addr & (HPAGE_SIZE - 1)) + len > HPAGE_SIZE : ^ 2 errors generated. vim +/HPAGE_SIZE +179 include/net/xsk_buff_pool.h 175 176 static inline bool xp_desc_crosses_non_contig_pg(struct xsk_buff_pool *pool, 177 u64 addr, u32 len) 178 { > 179 bool cross_pg = pool->hugetlb ? (addr & (HPAGE_SIZE - 1)) + len > HPAGE_SIZE : 180 (addr & (PAGE_SIZE - 1)) + len > PAGE_SIZE; 181 182 if (likely(!cross_pg)) 183 return false; 184 185 if (pool->dma_pages_cnt) { 186 return !(pool->dma_pages[addr >> PAGE_SHIFT] & 187 XSK_NEXT_PG_CONTIG_MASK); 188 } 189 190 /* skb path */ 191 return addr + len > pool->addrs_cnt; 192 } 193 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
