Re: [PATCH net v2 7/8] net/mlx5e: take into account device reconfiguration for xdp_features flag

Saeed Mahameed <saeed@xxxxxxxxxx> · Wed, 15 Mar 2023 19:46:10 -0700

On 15 Mar 17:29, Jakub Kicinski wrote:
On Wed, 15 Mar 2023 16:39:00 -0700 Jakub Kicinski wrote:

diff --git a/net/core/xdp.c b/net/core/xdp.c
index 87e654b7d06c..5722a1fc6e9e 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -781,6 +781,9 @@ void xdp_set_features_flag(struct net_device *dev, xdp_features_t val)
                return;

        dev->xdp_features = val;
+
+       if (dev->reg_state < NETREG_REGISTERED)
+               return;
        call_netdevice_notifiers(NETDEV_XDP_FEAT_CHANGE, dev);
 }
 EXPORT_SYMBOL_GPL(xdp_set_features_flag);

? The notifiers are not needed until the device is actually live.

I think so.. let me send a full patch.

We have an  internal version of a fix, Tariq is finalizing some review
comments and we will be posting it ASAP.







