On Tue, Feb 28, 2023 at 5:53 AM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Mon, Feb 20, 2023 at 6:54 PM <menglong8.dong@xxxxxxxxx> wrote: > > > > From: Menglong Dong <imagedong@xxxxxxxxxxx> > > > > In order to adapt to the older kernel, now we split the "attach_probe" > > testing into multi subtests: > > > > manual // manual attach tests for kprobe/uprobe > > auto // auto-attach tests for kprobe and uprobe > > kprobe-sleepable // kprobe sleepable test > > uprobe-lib // uprobe tests for library function by name > > uprobe-sleepable // uprobe sleepable test > > uprobe-ref_ctr // uprobe ref_ctr test > > > > As sleepable kprobe needs to set BPF_F_SLEEPABLE flag before loading, > > we need to move it to a stand alone skel file, in case of it is not > > supported by kernel and make the whole loading fail. > > > > Therefore, we can only enable part of the subtests for older kernel. > > > > Reviewed-by: Biao Jiang <benbjiang@xxxxxxxxxxx> > > Signed-off-by: Menglong Dong <imagedong@xxxxxxxxxxx> > > Reviewed-by: Alan Maguire <alan.maguire@xxxxxxxxxx> > > --- > > v3: > > - rename test_uporbe_ref_ctr() to test_uprobe_ref_ctr() to fix the > > typo > > --- > > > One of the patches in this patch set broke BPF CI ([0]), please take a look > > [0] https://github.com/kernel-patches/bpf/actions/runs/4267719970/jobs/7429701318 > It is caused by the fact that I didn't use OPTS_GET(), as you mentioned before. > > .../selftests/bpf/prog_tests/attach_probe.c | 268 +++++++++++------- > > .../bpf/progs/test_attach_kprobe_sleepable.c | 23 ++ > > .../selftests/bpf/progs/test_attach_probe.c | 23 +- > > 3 files changed, 208 insertions(+), 106 deletions(-) > > create mode 100644 tools/testing/selftests/bpf/progs/test_attach_kprobe_sleepable.c > > > > [...]
