Re: [RFC bpf-next 1/5] selftests/bpf: support custom per-test flags and multiple expected messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 28, 2023 at 2:30 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote:
>
> On Tue, 2023-02-28 at 10:53 -0800, Andrii Nakryiko wrote:
> > On Mon, Jan 23, 2023 at 6:52 AM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote:
> > >
> > > From: Andrii Nakryiko <andrii@xxxxxxxxxx>
> > >
> > > Extend __flag attribute by allowing to specify one of the following:
> > >  * BPF_F_STRICT_ALIGNMENT
> > >  * BPF_F_ANY_ALIGNMENT
> > >  * BPF_F_TEST_RND_HI32
> > >  * BPF_F_TEST_STATE_FREQ
> > >  * BPF_F_SLEEPABLE
> > >  * BPF_F_XDP_HAS_FRAGS
> > >  * Some numeric value
> > >
> > > Extend __msg attribute by allowing to specify multiple exepcted messages.
> > > All messages are expected to be present in the verifier log in the
> > > order of application.
> > >
> > > Signed-off-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
> > > [ Eduard: added commit message, formatting ]
> > > Signed-off-by: Eduard Zingerman <eddyz87@xxxxxxxxx>
> > > ---
> >
> > hey Eduard,
> >
> > When you get a chance, can you please send this patch separately from
> > the rest of the test_verifier rework patch set (it probably makes
> > sense to also add #define __flags in this patch as well, given you are
> > parsing its definition in this patch).
> >
> > This would great help me with my work that uses all this
> > assembly-level test facilities. Thanks!
>
> Hi Andrii,
>
> Rebase didn't change anything in the patch, I added __flags macro,
> some some comments, and started the CI job: [1].
>
> Feels weird to post it, tbh, because it's 100% your code w/o added
> value from my side.

you took the effort to prepare it for submission, testing, and
integrating into your work, so feels well deserved


>
> Thanks,
> Eduard
>
> [1] https://github.com/kernel-patches/bpf/pull/4688

apart from test flakiness, looks good, please send a patch "officially"

> >
> >
> >
> > >  tools/testing/selftests/bpf/test_loader.c | 69 ++++++++++++++++++++---
> > >  tools/testing/selftests/bpf/test_progs.h  |  1 +
> > >  2 files changed, 61 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/tools/testing/selftests/bpf/test_loader.c b/tools/testing/selftests/bpf/test_loader.c
> > > index 679efb3aa785..bf41390157bf 100644
> > > --- a/tools/testing/selftests/bpf/test_loader.c
> > > +++ b/tools/testing/selftests/bpf/test_loader.c
> > > @@ -13,12 +13,15 @@
> > >  #define TEST_TAG_EXPECT_SUCCESS "comment:test_expect_success"
> > >  #define TEST_TAG_EXPECT_MSG_PFX "comment:test_expect_msg="
> > >  #define TEST_TAG_LOG_LEVEL_PFX "comment:test_log_level="
> > > +#define TEST_TAG_PROG_FLAGS_PFX "comment:test_prog_flags="
> > >
> >
> > [...]
>




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux