On Thu, Feb 23, 2023 at 1:53 AM Puranjay Mohan <puranjay12@xxxxxxxxx> wrote:
>
> The syscall register definitions for ARM in bpf_tracing.h doesn't define
> the fifth parameter for the syscalls. Because of this some KPROBES based
> selftests fail to compile for ARM architecture.
>
> Define the fifth parameter that is passed in the R5 register (uregs[4]).
>
> Fixes: 3a95c42d65d5 ("libbpf: Define arm syscall regs spec in bpf_tracing.h")
> Signed-off-by: Puranjay Mohan <puranjay12@xxxxxxxxx>
> ---
> Changes in V1[1]->V2:
> - Fix signed-off-by and send-from emails.
>
> [1] https://lore.kernel.org/bpf/20230223094717.9746-1-puranjay12@xxxxxxxxx/T/#u
> ---
> tools/lib/bpf/bpf_tracing.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/lib/bpf/bpf_tracing.h b/tools/lib/bpf/bpf_tracing.h
> index 6db88f41fa0d..2cd888733b1c 100644
> --- a/tools/lib/bpf/bpf_tracing.h
> +++ b/tools/lib/bpf/bpf_tracing.h
> @@ -204,6 +204,7 @@ struct pt_regs___s390 {
> #define __PT_PARM2_SYSCALL_REG __PT_PARM2_REG
> #define __PT_PARM3_SYSCALL_REG __PT_PARM3_REG
> #define __PT_PARM4_SYSCALL_REG __PT_PARM4_REG
> +#define __PT_PARM5_SYSCALL_REG uregs[4]
that's an "interesting" omission on my part, thanks for catching and fixing!
> #define __PT_PARM6_SYSCALL_REG uregs[5]
> #define __PT_PARM7_SYSCALL_REG uregs[6]
>
> --
> 2.39.1
>
