On Fri, 2023-02-24 at 16:02 -0800, Alexei Starovoitov wrote: > On Thu, Feb 23, 2023 at 12:43 PM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> > wrote: > > > > On Thu, 2023-02-23 at 09:17 -0800, Alexei Starovoitov wrote: > > > On Wed, Feb 22, 2023 at 2:37 PM Ilya Leoshkevich > > > <iii@xxxxxxxxxxxxx> > > > wrote: > > > > > > > > v2: > > > > https://lore.kernel.org/bpf/20230215235931.380197-1-iii@xxxxxxxxxxxxx/ > > > > v2 -> v3: Drop BPF_HELPER_CALL (Alexei). > > > > Drop the merged check_subprogs() cleanup. > > > > Adjust arm, sparc and i386 JITs. > > > > Fix a few portability issues in test_verifier. > > > > Fix a few sparc64 issues. > > > > Trim s390x denylist. > > > > > > I don't think it's a good idea to change a bunch of JITs > > > that you cannot test just to address the s390 issue. > > > Please figure out an approach that none of the JITs need changes. > > > > What level of testing for these JITs would you find acceptable? > > Just find a way to avoid changing them. Ok. But please take a look at patches 1-6. They fix existing issues, which were found by running test_verifier on arm and sparc64.
