On 2023/2/27 12:02, Randy Dunlap wrote:
bpf_jit_comp64.c uses patch_text(), so add it to a local header file
to prevent the build error:
../arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_arch_text_poke':
../arch/riscv/net/bpf_jit_comp64.c:691:23: error: implicit declaration of function 'patch_text'; did you mean 'path_get'? [-Werror=implicit-function-declaration]
691 | ret = patch_text(ip, new_insns, ninsns);
| ^~~~~~~~~~
Fixes: 596f2e6f9cf4 ("riscv, bpf: Add bpf_arch_text_poke support for RV64")
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Link: https://lore.kernel.org/r/202302271000.Aj4nMXbZ-lkp@xxxxxxxxx
Cc: Pu Lehui <pulehui@xxxxxxxxxx>
Cc: Luke Nelson <luke.r.nels@xxxxxxxxx>
Cc: Xi Wang <xi.wang@xxxxxxxxx>
Cc: bpf@xxxxxxxxxxxxxxx
Cc: Alexei Starovoitov <ast@xxxxxxxxxx>
Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
Cc: John Fastabend <john.fastabend@xxxxxxxxx>
Cc: Andrii Nakryiko <andrii@xxxxxxxxxx>
Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>
Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
Cc: "Björn Töpel" <bjorn@xxxxxxxxxx>
Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
---
What is the proper path to have this merged soon to stop build
errors?
arch/riscv/net/bpf_jit.h | 1 +
1 file changed, 1 insertion(+)
diff -- a/arch/riscv/net/bpf_jit.h b/arch/riscv/net/bpf_jit.h
--- a/arch/riscv/net/bpf_jit.h
+++ b/arch/riscv/net/bpf_jit.h
@@ -12,6 +12,7 @@
#include <linux/bpf.h>
#include <linux/filter.h>
#include <asm/cacheflush.h>
+#include <asm/patch.h>
Thanks Randy. Since patch_text is only used in riscv64 at present, I
think it is appropriate to add it to arch/riscv/net/bpf_jit_comp64.c
static inline bool rvc_enabled(void)
{
