Re: [PATCH bpf-next 2/2] selftests/bpf: Tests for uninitialized stack reads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2023-02-17 at 14:00 -0800, Andrii Nakryiko wrote:
[...]
> > Orthogonal to the above issue, I found that use of the '//' comments
> > in the asm code w/o newlines is invalid, as it makes rest of the
> > string a comment. I changed '\n\' line endings to '\' just before
> > sending the patch and did not verify the change.
> > => The patch-set would have to be resent.
> 
> I was wondering about that, but assumed you tested it ;) so yeah,
> please fix and resend. (in that sense having each line separately
> quoted allows much easier commenting, but we've decided on this style,
> so let's stick to it

And syntax highlighting for strings vs comments :'(

Thank you for the replies, I'll update the patch #1 and resend.

[...]




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux