Re: [PATCH bpf-next] selftests/bpf: Remove not used headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/16/23 7:31 PM, Stanislav Fomichev wrote:
On 02/16, Tiezhu Yang wrote:
The following three uapi headers:

     tools/arch/arm64/include/uapi/asm/bpf_perf_event.h
     tools/arch/s390/include/uapi/asm/bpf_perf_event.h
     tools/arch/s390/include/uapi/asm/ptrace.h

were introduced in commit 618e165b2a8e ("selftests/bpf: sync kernel headers
and introduce arch support in Makefile"), they are not used any more after
commit 720f228e8d31 ("bpf: fix broken BPF selftest build"), so remove them.

Let's maybe CC Arnaldo to make sure it doesn't affect perf? BPF build
bots are happy it seems.

Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
---
  tools/arch/arm64/include/uapi/asm/bpf_perf_event.h |   9 -
  tools/arch/s390/include/uapi/asm/bpf_perf_event.h  |   9 -
  tools/arch/s390/include/uapi/asm/ptrace.h          | 458 ---------------------
  3 files changed, 476 deletions(-)
  delete mode 100644 tools/arch/arm64/include/uapi/asm/bpf_perf_event.h
  delete mode 100644 tools/arch/s390/include/uapi/asm/bpf_perf_event.h
  delete mode 100644 tools/arch/s390/include/uapi/asm/ptrace.h

Lgtm, I think test_verifier.c was the only user via ...

  - include/uapi/linux/bpf_perf_event.h
    -> include/uapi/asm/bpf_perf_event.h
       -> arch/*/include/uapi/asm/bpf_perf_event.h

... but we're actually pulling in the arch includes instead of the tooling
arch include. So these look indeed unused.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux